Open
Conversation
auberonedu
reviewed
Jan 22, 2025
Comment on lines
+50
to
+53
| for (String keys : mapPractice.keySet()) | ||
| { | ||
| System.out.println(keys + " and " + mapPractice.get(keys)); | ||
| } |
There was a problem hiding this comment.
This works! In the future, you could also consider entrySet
Comment on lines
43
to
+46
| // Join all of the strings in the list together into a single string separated by commas | ||
| // Use a built-in method to achieve this instead of using a loop | ||
| String comp = listStrings.toString(); | ||
| System.out.println(comp); |
There was a problem hiding this comment.
I like the idea here! We do technically get the strings joined by commas, but we also get extra square brackets and spaces which we may not want. Consider using the join method in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.